-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix multiple typos #6975
base: master
Are you sure you want to change the base?
fix multiple typos #6975
Conversation
@bkchr Cool, I'm glad my changes helped you, and I'll be much obliged if this PR will become merged, tnx for your review! |
@@ -18,7 +18,7 @@ on: | |||
|
|||
jobs: | |||
check-synchronization: | |||
uses: paritytech-release/sync-workflows/.github/workflows/check-syncronization.yml@main | |||
uses: paritytech-release/sync-workflows/.github/workflows/check-synchronization.yml@main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to update the pointed file:
https://github.com/paritytech-release/sync-workflows/blob/main/.github/workflows/check-syncronization.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to update the pointed file: https://github.com/paritytech-release/sync-workflows/blob/main/.github/workflows/check-syncronization.yml
you want me to update the name of the file, or to revert changes with "syncroninzation" to "synchronization"
If I change the name of the pointed file, then probably there other files I dont know about that mention "check-syncronization", and it means there will be problems in code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this single change is ok to me.
Otherwise we should try to ping some CI people to get their opinion I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting this single change is ok to me.
Otherwise we should try to ping some CI people to get their opinion I guess.
made a PR with changes in the file you send here above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one paritytech-release/sync-workflows#6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crStiv This updated will be needed in other release workflows as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crStiv This updated will be needed in other release workflows as well
@EgorPopelyaev @gui1117
look, okay, I got it, but what should I do?
I can simply leave the typo with "synchronization" like it was before (revert this typo), or you can tell me what are the release workflows need to be changed as well and I'll try to take care of them,
I think to leave it as it was before my changes would be optimal, what do you think?
Review required! Latest push from author must always be reviewed |
Description
This pull request addresses a series of minor typos and formatting issues across various scripts and configuration files in the repository. These changes ensure better readability, accuracy, and adherence to coding standards. The typos corrected include:
Integration
The changes are self-contained and do not require specific integration steps. All updates are related to documentation, comments, and non-functional text changes within scripts and workflows. No runtime behavior or logic is affected, and downstream projects can safely adopt these updates without risk of regression.
Review Notes
The review should focus on verifying that:
Below are some examples of the changes: